Fix Jakarta EE 10 web.xml migration#1159
Merged
timtebeek merged 1 commit intoJul 8, 2026
Merged
Conversation
timtebeek
reviewed
Jul 1, 2026
Comment on lines
+49
to
+50
| - org.openrewrite.FindSourceFiles: | ||
| filePattern: '**/web.xml' |
Member
There was a problem hiding this comment.
Might this be misplaced? As the precondition here will only match web.xml files, which means none of the ChangeDependency recipes it guards will ever match or make changes.
Member
There was a problem hiding this comment.
Did you intend to add the precondition only to name: org.openrewrite.java.migrate.jakarta.JavaxWebXmlToJakartaWebXml ?
Contributor
Author
There was a problem hiding this comment.
Thanks, you were right. The FindSourceFiles precondition was misplaced and was guarding UpdateJakartaFacesApi3. I moved it to only JavaxWebXmlToJakartaWebXml.
Verified:
UpdateJakartaFacesApiTestJavaxWebXmlToJakartaWebXmlTestJakartaEE10Test
sakshichitnis27
force-pushed
the
fix/7471-jakarta-web-xml-ee10
branch
from
92e420e to
d0b34c5
Compare
timtebeek
approved these changes
Jul 8, 2026
timtebeek
left a comment
timtebeek
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks a lot for the fix here! Good to keep these files XML to allow chaining recipes.
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the plain text
FindAndReplacesteps forweb.xmlwith XML-awareChangeTagValuesteps soweb.xmlremains an XML LST. This allows the laterJakartaWebXml6recipe in theJakartaEE10chain to updateweb.xmlfrom version5.0to6.0.Adds a regression test for the
JakartaEE10chain.Verified:
./gradlew test --tests "org.openrewrite.java.migrate.jakarta.JavaxWebXmlToJakartaWebXmlTest"./gradlew test --tests "org.openrewrite.java.migrate.jakarta.JakartaEE10Test"